Skip to content

Add coverage testing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 80 commits into from
May 22, 2025
Merged

Add coverage testing #21

merged 80 commits into from
May 22, 2025
+1,910 −258

Conversation

brahyt-sf
Copy link
Contributor

@brahyt-sf brahyt-sf commented May 12, 2025 •
edited
Loading

You can run testing with yarn coverage

[1]   110 passing (25s)
[1]   3 pending
[1]
[1] mocha exited with code 0
--> Sending SIGTERM to other processes..
[0] wiremock exited with code SIGTERM

=============================== Coverage summary ===============================
Statements   : 93.75% ( 360/384 )
Branches     : 82.29% ( 79/96 )
Functions    : 100% ( 114/114 )
Lines        : 93.66% ( 355/379 )
================================================================================
✨  Done in 28.23s.

brahyt-sf
brahyt-sf commented May 12, 2025
View reviewed changes
@brahyt-sf brahyt-sf force-pushed the add-test-coverage branch from bdda439 to 5dd6541 Compare May 12, 2025 19:05
@brahyt-sf brahyt-sf marked this pull request as ready for review May 12, 2025 19:14
ekozilforce
ekozilforce reviewed May 12, 2025
View reviewed changes
ekozilforce
ekozilforce reviewed May 12, 2025
View reviewed changes
ekozilforce
ekozilforce reviewed May 12, 2025
View reviewed changes
@ekozilforce
Copy link
Collaborator

ekozilforce commented May 12, 2025 •
edited
Loading

Needs a npm run format:write to get past the format check in ci

@brahyt-sf brahyt-sf force-pushed the add-test-coverage branch from b01c52d to b99b349 Compare May 12, 2025 22:46
brahyt-sf
brahyt-sf commented May 15, 2025
View reviewed changes
README.md Outdated

### Running tests
To test with coverage run `yarn coverage`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn test:coverage

@brahyt-sf brahyt-sf requested a review from a team as a code owner May 19, 2025 20:31
@brahyt-sf brahyt-sf requested a review from ekozilforce May 22, 2025 03:38
ekozilforce
ekozilforce reviewed May 22, 2025
View reviewed changes
@ekozilforce ekozilforce mentioned this pull request May 22, 2025
Merged
@brahyt-sf brahyt-sf force-pushed the add-test-coverage branch from f7d4a5c to c319ae7 Compare May 22, 2025 15:53
@brahyt-sf brahyt-sf force-pushed the add-test-coverage branch 2 times, most recently from 07f01d8 to ca7b5e2 Compare May 22, 2025 17:01
ekozilforce
ekozilforce reviewed May 22, 2025
View reviewed changes
.github/workflows/build.yml Outdated
Comment on lines 35 to 38
if: runner.os != 'macOS'

- run: yarn test:coverage
if: runner.os == 'macOS'
Copy link
Collaborator

@ekozilforce ekozilforce May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If macos isn't working due to the java heap running out of memory and we don't have a path to fix, we could remove it from the os matrix temporarily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do.

@ekozilforce ekozilforce self-requested a review May 22, 2025 19:23
ekozilforce
ekozilforce approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@ekozilforce ekozilforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement and this should close out multiple items on DoD.

I want to get this merged so we can get faster feedback as we make code changes, but we should circle back and get macos running in our test matrix before GA ideally.

@brahyt-sf brahyt-sf merged commit c6940a5 into main May 22, 2025
6 of 8 checks passed
@ekozilforce ekozilforce deleted the add-test-coverage branch May 22, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekozilforce ekozilforce ekozilforce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brahyt-sf @ekozilforce